Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt dependencies due to core changes #18214

Merged
merged 4 commits into from
Feb 15, 2025
Merged

Adapt dependencies due to core changes #18214

merged 4 commits into from
Feb 15, 2025

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Feb 2, 2025 •
edited
Loading

  • junit, cxf, javassist, hamcrest
  • [tradfri] Adapt NetworkConfig to new Californium API
  • [shelly] Adapt NetworkConfig to new Californium API
  • [modbus.itests] Temporarily disable some test steps which fail with hamcrest3

Depends on core change, openhab/openhab-core#4584

@holgerfriedrich holgerfriedrich added the awaiting other PR Depends on another PR label Feb 2, 2025
@holgerfriedrich holgerfriedrich mentioned this pull request Feb 2, 2025
Merged
hmerk
hmerk approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@hmerk hmerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich holgerfriedrich removed the awaiting other PR Depends on another PR label Feb 13, 2025
@wborn
Copy link
Member

wborn commented Feb 14, 2025

Looks like some Tradfri changes are still needed.

@holgerfriedrich
Copy link
Member Author

Yes, I will have a look.

@holgerfriedrich
Copy link
Member Author

holgerfriedrich commented Feb 15, 2025 •
edited
Loading

Unfortunately, the changes in core introduced more problems in add-ons repo than expected. Don't what happened with my local build when I created the PR.

Californium library used by shelly and tradfri has changed the API for network configuration. Thanks to the itests, I have a good feeling that it will work. Though, cannot test as I don't have such devices.

Modbus itest has some issues with the new hamcrest 3.0 library. I was not able to fix this until now.
As the add-on build is currently broken, I decided to disable the affected test steps for now.

wborn
wborn approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit d6ef92e into openhab:main Feb 15, 2025
2 checks passed
@wborn wborn added this to the 5.0 milestone Feb 15, 2025
@holgerfriedrich holgerfriedrich deleted the pr-upgrades branch February 15, 2025 10:36
@holgerfriedrich holgerfriedrich mentioned this pull request Feb 16, 2025
Open
@lsiepel
Copy link
Contributor

lsiepel commented Feb 18, 2025 •
edited
Loading

@holgerfriedrich since this PR the hue and feed itests fail. When building this itest project locally i get bnd errors: (46)

Error   : org.hamcrest;version=[3.0.0,3.0.1) Not found in [bnd-cache [C:/oh-dev/openhab-
addons/itests/org.openhab.binding.hue.tests/target/test/tmp/testing/itest/cnf/cache/7.1.0/bnd-cache r/w=false], org.openhab.core.bom.runtime-index 
[C:\oh-dev\openhab-addons\itests\org.openhab.binding.hue.tests\target\test\tmp\testing\itest\cnf\cache\7.1.0\org.openhab.core.bom.runtime-index r/w=false], org.openhab.core.bom.test-index 
[C:\oh-dev\openhab-addons\itests\org.openhab.binding.hue.tests\target\test\tmp\testing\itest\cnf\cache\7.1.0\org.openhab.core.bom.test-index r/w=false], org.openhab.core.bom.openhab-core-index 
[C:\oh-dev\openhab-addons\itests\org.openhab.binding.hue.tests\target\test\tmp\testing\itest\cnf\cache\7.1.0\org.openhab.core.bom.openhab-core-index r/w=false], self 
[C:\oh-dev\openhab-addons\itests\org.openhab.binding.hue.tests\target\test\tmp\testing\itest\cnf\cache\7.1.0\self r/w=false], openHAB Add-ons :: Integration Tests :: hue Binding Tests [org.openhab.binding.hue;version=5.0.0.202502151057,org.openhab.binding.hue.tests;version=5.0.0.202502181803,org.lastnpe.eea:eea-all;version=2.4.0 r/w=false]]

Do we need to upload some dependencies or why can;t these be resolved?

@holgerfriedrich
Copy link
Member Author

openhab/openhab-core#4608 was just merged and core build completed. Hopefully this fixes the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmerk hmerk hmerk approved these changes

@wborn wborn wborn approved these changes

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@mherwege mherwege Awaiting requested review from mherwege mherwege is a code owner

@marcelrv marcelrv Awaiting requested review from marcelrv marcelrv is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@antroids antroids Awaiting requested review from antroids antroids is a code owner

@BjoernLange BjoernLange Awaiting requested review from BjoernLange BjoernLange is a code owner

@markus7017 markus7017 Awaiting requested review from markus7017 markus7017 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@holgerfriedrich @wborn @lsiepel @hmerk